nanocoap_sock: always use coap_opt_put_uri_pathquery()

[benpicco]

Contribution description

This is pretty subtle: coap_opt_put_uri_pathquery() will detect the presense of a query parameter, coap_opt_put_uri_path() will not.

That means that when you request path/to/resource?option=1 with coap_opt_put_uri_path() you get the path resource?option=1 whereas with coap_opt_put_uri_pathquery() you get the path resource with query parameter option=1.

We really want the latter.

Testing procedure

Issues/PRs references

[riot-ci]

Murdock results

:heavy_check_mark: PASSED

eb76b8ea628e54f0277115cb0fbb6df37e91092d nanocoap: allow lastonum=NULL in coap_opt_put_uri_pathquery()

Success	Failures	Total	Runtime
8101	0	8101	10m:26s

Artifacts

• Documentation preview

[benpicco]

To me it feels more like a bug fix than an API change - when I added the functions I was not aware of the difference between coap_opt_put_uri_pathquery() and coap_opt_put_uri_path() (or that there are in fact two different functions) :sweat_smile:

[benpicco]

Is there anything I can do to move this forward?

[benpicco]

Thank you!