Benny Neugebauer

Results 149 comments of Benny Neugebauer

Meanwhile I built my own [hexo-insert-toc](https://github.com/bennycode/hexo-insert-toc) plugin which allows me to create a table of contents by placing a `` in my Markdown files.

@hardchor Thanks for referencing your CircleCI configuration. From your configuration I can see that it runs `greenkeeper-lockfile-update` and `greenkeeper-lockfile-upload` but doesn't it also need to run ` yarn global add...

I got it working! Thank you so much @hardchor! Here is my running configuration: ```yaml version: 2 jobs: build: # https://circleci.com/docs/2.0/circleci-images/#nodejs docker: - image: node:8.0 # https://circleci.com/docs/2.0/configuration-reference/#steps steps: - run:...

I think the problem here is Prettier's exit code. I was able to fix this problem with a workaround by using [pretty-quick](https://www.npmjs.com/package/pretty-quick): **lefthook.yml** ```yml pre-commit: parallel: true commands: prettier: run:...

@acravenho can you allow maintainers to edit your PR? This would help us adjusting the Prettier styling and merging your PR.

@acravenho Great! Please verify if the "Allow edits from maintainers" box is checked: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests @balthazar Do you have "Edit" permissions when you check the [files changed](https://github.com/Ashlar/binance-api-node/pull/226/files)?

@hdmark can you turn your changes into a PR so it is easier for me to verify your changes?

@hp8wvvvgnj6asjm7 the "binance-api-node" already uses the [reconnecting-websocket](https://github.com/pladaria/reconnecting-websocket) package, so what would you like to add to check the WebSocket connection?

@balthazar we should look into options to generate TypeScript definitions OR progressively migrate this codebase to TypeScript. TypeScript can handle standard JavaScript with ease (using the [allowJs](https://www.typescriptlang.org/tsconfig#allowJs) compiler flag), so...

Greetings, everyone! 👋 As a user of the `convert-units` library, I got excited to test [version 3 (beta 5)](https://github.com/convert-units/convert-units/releases/tag/v3.0.0-beta.5). I'm very happy to see that this library is still actively...