binance-api-node icon indicating copy to clipboard operation
binance-api-node copied to clipboard

Further development on the Margin Trading API

Open acravenho opened this issue 5 years ago • 4 comments

Added the following endpoints:

  • margin trading order history
  • transfer
  • borrow (loan)
  • max borrow
  • repay
  • repay history
  • margin order history
  • margin assets
  • max transferable

acravenho avatar Jan 11 '20 08:01 acravenho

@acravenho can you allow maintainers to edit your PR? This would help us adjusting the Prettier styling and merging your PR.

bennycode avatar May 31 '20 11:05 bennycode

@bennyn No problem at all. Sorry, I've been super busy.

acravenho avatar May 31 '20 12:05 acravenho

@acravenho Great! Please verify if the "Allow edits from maintainers" box is checked: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

@balthazar Do you have "Edit" permissions when you check the files changed?

bennycode avatar May 31 '20 12:05 bennycode

@bennyn I do not, but you could fork his branch and submit a new PR with your updates, so you don't have to wait on it

balthazar avatar Jun 01 '20 01:06 balthazar