Benny Neugebauer
Benny Neugebauer
I noticed that `1m` and `1M` have the same value when using "ms" which is `60000`. This is very confusing since I expect `1m` to be one minute and `1M`...
@kamilmysliwiec can you point me to the code which generates the files? I want to try implementing support for file names in PascalCase. 🙂
@anandanand84 your [Stochastic Oscillator implementation](https://github.com/anandanand84/technicalindicators/blob/v3.1.0/src/momentum/Stochastic.ts) is very different from the results of the famous [Tulip Indicators](https://github.com/TulipCharts/tulipindicators). I used the values from the [Example Calculation](https://tulipindicators.org/stoch) of Tulip Indicators and created a...
@Godnyx in our app we need to update a lot of lists (conversation list, messages list, list of participants, etc.). That's where [Knockout's observables](https://knockoutjs.com/documentation/observables.html) don't perform well and where we...
@ovflowd I noticed that this PR touched the docs of the Node.js event loop which are currently down: https://nodejs.dev/learn/the-nodejs-event-loop Do you know what's the problem here? https://user-images.githubusercontent.com/469989/185747544-eefaebf3-ae1f-493b-b1da-adb556e3ec6f.mp4
Thanks for the feedback. Happy to hear that a fix has been already found. Keep up the good work. 👍
Hi @hjoelr. No need to be sorry! I am very happy that you put so much thought in this library. Can you exchange `?.` with `!.`? I am infavor of...
Is this line 405 that you want to test? https://github.com/bennycode/coinbase-pro-node/blob/48d4dbc04754c5ed28acb95feb8fe3506703f99d/src/client/WebSocketClient.ts#L405 If yes, then the coverage tool wants you to test the positive case and the negative case for that if-condition....
Can you rebase it with the "main" branch? I will try to review it then next week (I am off for the weekend).
Hi @[hjoelr](https://github.com/hjoelr), unfortunately I didn't check your PR as expected. Is it still relevant? Can we move portions of it into new PRs to merge it bit-by-bit without breaking any...