Ben McCann

Results 1653 comments of Ben McCann

this is a very marginal PR. I think it was probably fine before. This is arguably an improvement, but it's not clear. I'll go ahead and merge this, but we...

It probably would have been preferred to just send a single PR with the docs changes since they're all so small. I'll go ahead and merge this though

> There were more such places inside the sveltekit codebase, seems not related, since its not customer facing, but might still be worth updating. Yes, please! PRs welcome to reduce...

I converted this to draft since we should be able to simply test it on this branch without merging it

There's a few PRs dealing with this, so I opened an issue so that we can have a single place to discuss: https://github.com/sveltejs/kit/issues/8578 (or now we have four places instead...

@jrf0110 tagging you in case you or anyone else from Cloudflare might be interested in giving this one a look. We no longer have any Svelte maintainers employed at Cloudflare...

I haven't seen that. Can you share a project that reproduces the issue?

>npm ERR! Found: [email protected] npm ERR! node_modules/vite npm ERR! dev vite@"^3.0.4" from the root project That sounds like you still have Vite 3 in a `package.json` somewhere. Another thing you...

I'm not sure how I feel about this. Service workers stick around in the browser so if you run one app with a service worker and then run a different...

Yes, you'd probably have that problem with any form of service worker. Making it unused would be fine. Perhaps it would be clearer to call it something like `disabled-service-worker.js` than...