Ben McCann

Results 1592 comments of Ben McCann

Couldn't you upgrade prettier first and then do the Svelte 5 upgrade after that?

thank you! closing this since we have the omnisite, but happy to get any of these changes there

It would be good to have a test for this. Do we have any tests currently for preloading code? I'm a bit surprised this wouldn't have been caught by our...

The build test failures seem to be real since they're failing in every browser. Could you take a look at those?

I can't reproduce this, so assume it's fixed. We've merged svelte.dev and kit.svelte.dev together into a single site, so that the site-kit now lives here: https://github.com/sveltejs/svelte.dev/tree/main/packages/site-kit I'm going to close...

@anncwb @jinmao88 any chance you might be able to take a look at this? thanks!

@anncwb @jinmao88 just gently checking in on this It's worth mentioning that Vite itself has now switched to `tinyglobby`, so this would allow the library to be deduped so that...

hmm. yeah. I'm glad we have your arcane knowledge of JS because I had no idea that was a thing I'll try to solve this on the Vite side then:...

I'd hate to make deduping worse by pinning these. I'm watching both repos, so we shouldn't get surprised. And I doubt he wants to invite more drama by messing with...

yeah, I don't really care about making those work on Deno. But the easiest way to avoid regressions in the real code is just enable the eslint check for it...