svelte
svelte copied to clipboard
chore: pin aria-query and axobject-query
Now that the version of aria-query without dequal has finally been published and we've upgraded to it, I'd like to (as I had previously mentioned in Discord) pin both this and axobject-query so that we don't have any unpleasant surprises in the future. If these packages eventually have updates that we do want, we can revisit then.
Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).
If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.
Before submitting the PR, please make sure you do the following
- [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- [x] Prefix your PR title with
feat:,fix:,chore:, ordocs:. - [x] This message body should clearly illustrate what problems it solves.
- [ ] Ideally, include a test that fails without this PR but passes with it.
Tests and linting
- [x] Run the tests with
pnpm testand lint the project withpnpm lint
🦋 Changeset detected
Latest commit: 6480a70cbb0d325e1f79aec62b6a1ec2ffd3cb68
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| svelte | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
I'd hate to make deduping worse by pinning these. I'm watching both repos, so we shouldn't get surprised. And I doubt he wants to invite more drama by messing with these
yeah i think i probably come down on the side of not pinning for the sake of deduping (not that it's hugely important in contexts where the compiler is used). vigilance is required either way (whether to keep an eye out for inane bullshit because we haven't pinned, or to keep up to date with any desirable updates because we have) — a shame but that is the price of using packages for which he has acquired the commit bit
That's fair. Maybe the new sponsorship links will make him even more drama averse because the stakes are now higher. Maybe! I'm fine not pinning these.