Ben McCann

Results 1638 comments of Ben McCann

I'm saying that while this change helps Deno I don't think we need to commit to making build scripts work on Deno. I'm just doing it here out of convenience...

The eslint rule checks that `process` is imported The eslint rules live in another repo: https://github.com/sveltejs/eslint-config

Hmm, doesn't look like the fix worked. Running `npx svelte-migrate@latest svelte-5` in the `web` directory of https://github.com/immich-app/immich still spits out lots of errors

Yeah, I see a bunch of errors like: ``` Error while migrating Svelte code migrate.svelte:45:7 `$$Props` is an illegal variable name. To reference a global variable called `$$Props`, use `globalThis.$$Props`...

wtf. now it worked after trying like 5 times 15 minutes ago. must be some weird npx caching

Thanks so much for sharing this! There is an official migration tool that's in progress: https://github.com/sveltejs/kit/pull/12519 I expect at least some of these migrations should be handled by that tool...

> though this does serve as a reminder that we should expedite publishing the tool It's pretty much done. I had one suggestion for improving handling of unexpected errors (https://github.com/sveltejs/kit/pull/12519#issuecomment-2343996005),...

I think we've already done that. We've got `binding.mutated` and `binding.reassigned` so I think it'd be a pretty easy check to add

Actually template strings already do string coercion, so I wonder if we even need the `$.stringify` in other cases https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String#string_coercion