Benjamin Gruenbaum comments

Results 788 comments of


                                            Benjamin Gruenbaum

Redesign of the Node.js API Docs

> Hey, @nodejs/tsc I'd like to pin this issue, due to its high-visibility and impact on the project. Pins are typically used in order to catch cases we have breakages/bugs...

test_runner: add suite hooks

> This is a proposal to add suite hooks to the test runner. Makes it possible to add setup and teardown for an entire suite. Hey, thanks for the PR!...

test_runner: check if timeout was cleared by own callback

Nice catch!

buffer: fix DoS vector in atob

I am fine with landing this (since it's an improvement) but no benchmarks. (as a side note nice seeing you back!)

--watch should monitor replaced files

@MoLow

lib: add EventSource

(LGTM is in principle, this is a draft)

Allow to run tests in the main process

Sounds like a legitimate feature to me

Fail for missing env file in development only

@GeoffreyBooth > I don’t buy the argument that Node should just warn or ignore the error; you asked Node to load a file, and it couldn’t, so it should error....

Some way of not displaying skipped or filtered tests in the spec test reporter

@nodejs/test_runner not displaying filtered out tests seems reasonable to me wdyt?

Test runner: spurious "Promise resolution is still pending but the event loop has already resolved" when a callback tests fails

@nodejs/test_runner @MoLow I think in any case the callback test failing shouldn't interfere with any of the other tests. Re: the second example - The "fail the test file for...