Benjamin Gruenbaum
Benjamin Gruenbaum
I vote "throw on non-existing env file" and "throw on multiple `--env-file` parameters" since those are easy to change later and lets us land without waiting for a decision on...
Hey, Great to see users are asking for this! As others have mentioned this is "on the roadmap" and we started adding `Symbol.dispose` and `Symbol.asyncDispose` support to all APIs. You...
I'm wondering if we should ship a `defer` helper since you can absolutely `await using` the file in your case which would close it but you would have to wrap...
> Is there a difference between v8 crashing and node crashing? Couldn't node still run cleanup before exiting in case of v8 crash? My point is that users cannot rely...
What APIs would you expect support in other than streams/files @brillout ?
@luchillo17 note that for some cases we expose Symbol.asyncDispose where appropriate https://nodejs.org/api/stream.html#readablesymbolasyncdispose The main issue in terms of DX is that because we're a JS and not a TS runtime...
@brillout I maintain a package (tmp-promise) with a disposer pattern that could use an update but I'm not aware of anything in core. I think we can probably ship a...
@ronag > Implement for stream.Writable as well? Yeah, and for a lot of other things (http.Server etc), the idea here was to add the symbols and one example so we...
> The [notable-change](https://github.com/nodejs/node/issues?q=is%3Aopen+label%3Anotable-change+sort%3Aupdated-desc) PRs with changes that should be highlighted in changelogs.label has been added by @benjamingr. Node is adding support to the [explicit resource management](https://github.com/tc39/proposal-explicit-resource-management) proposal to its resources...
I think it's an unrelated flaky tests let me try to "resume ci" (run just the failing parts) and see.