Benjamin Gruenbaum comments

Results 788 comments of


                                            Benjamin Gruenbaum

fs.glob add option to only include files (not directories) in the results entries

@MoLow

fs.glob add option to only include files (not directories) in the results entries

Maybe just expose the dirent insstead of its name to exclude which would enable: ```js fs.promises.glob("foo/**", { exclude(entry) { return entry.isFile(); }) ```

`Reflect.has` triggers getters on global object contextified by `vm`

Can confirm this repros on v20.12.2 but not on v22.0, I recall a fix (by @fhinkel ?) for something in that space a few months ago.

inspector: introduce the `--inspect-wait` flag

I'm not sure I understand the use case? Shouldn't this be solved from the consumer side that can call `Debugger.resume` (or some such) after attaching with `--inspect-brk`?

Inconsistent presence of property in contextified object

@nodejs/vm

Inspector not starting with --watch flag before

@MoLow

Tracking issue: compile cache

> Avoid UTF8 transcoding by directly reading the source code as buffer from disk (this needs to dance with CJS loader monkey patching) FWIW I think loaders/require hooks are probably...

test_runner: display failed test stack trace with dot reporter

> It looks okay, but I don't want to approve/request changes until a CI is ran. You're welcome to review code changes (as in make recommendations) but note your approval/request-changes...

src: rewrite task runner in c++

Maybe we should rename it script runner if this keeps getting happening 😅

Comment field on `crypto.generateKeyPair`

@nodejs/crypto