node lib: add EventSource

Proposal for Release Notes:

EventSource

EventSource is a W3C compliant Client for Server-sent events. The new flag --experimental-eventsource can be used to expose a global EventSource-constructor.

Jan 26 '24 23:01 Uzlopak

Review requested:

[ ] @nodejs/security-wg

Jan 26 '24 23:01 nodejs-github-bot

(LGTM is in principle, this is a draft)

Jan 27 '24 11:01 benjamingr

@Uzlopak this can move forward now

Apr 14 '24 20:04 KhafraDev

Roger that.

Apr 14 '24 21:04 Uzlopak

@KhafraDev

PTAL

Apr 14 '24 22:04 Uzlopak

cc @nodejs/web-standards

Apr 14 '24 23:04 KhafraDev

Can this be a notable change ;)?

Apr 15 '24 00:04 Uzlopak

The https://github.com/nodejs/node/labels/notable-change label has been added by @marco-ippolito.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

Apr 15 '24 06:04 github-actions[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58390/

Apr 15 '24 07:04 nodejs-github-bot

Can somebody please add author-ready flag?

@RafaelGSS Is the description ok?

Apr 16 '24 00:04 Uzlopak

Can somebody please add author-ready flag?

@RafaelGSS Is the description ok?

Can you expand a bit more? For author ready CI must be green

Apr 16 '24 05:04 marco-ippolito

CI: https://ci.nodejs.org/job/node-test-pull-request/58422/

Apr 16 '24 08:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/58435/

Apr 16 '24 14:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/58783/

Apr 28 '24 15:04 nodejs-github-bot

@Uzlopak there are conflicts snow

Apr 29 '24 11:04 mcollina

@mcollina

PTAL

May 05 '24 11:05 Uzlopak

CI: https://ci.nodejs.org/job/node-test-pull-request/58960/

May 05 '24 15:05 nodejs-github-bot

For author ready CI must be green

@marco-ippolito running CI is enough to be author ready

https://github.com/nodejs/node/blob/956521c767e9bad13f7737c518ad5ce368c349c2/doc/contributing/collaborator-guide.md#L895-L899

May 11 '24 15:05 aduh95

For author ready CI must be green

@marco-ippolito running CI is enough to be author ready

https://github.com/nodejs/node/blob/956521c767e9bad13f7737c518ad5ce368c349c2/doc/contributing/collaborator-guide.md#L895-L899

Thanks for clarifying, I was sure it required green ci 😵

May 11 '24 15:05 marco-ippolito

@aduh95

done ;)

May 11 '24 23:05 Uzlopak

CI: https://ci.nodejs.org/job/node-test-pull-request/59133/

May 11 '24 23:05 nodejs-github-bot

I find it surprising that there are no WPT changes, but that shouldn't block this from landing.

wdym? we run WPTs for it in undici

May 12 '24 01:05 KhafraDev

wdym? we run WPTs for it in undici

I would expect that we run WPT tests for it in this repo.

May 12 '24 08:05 aduh95

wdym? we run WPTs for it in undici

I would expect that we run WPT tests for it in this repo.

We don't run wpts for fetch either on this as far as I know.

May 12 '24 08:05 mcollina

CI: https://ci.nodejs.org/job/node-test-pull-request/59180/

May 12 '24 18:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59194/

May 12 '24 19:05 nodejs-github-bot

Landed in 1d7d094a981b62f900994284f3d1ab44ec533302

May 13 '24 05:05 nodejs-github-bot

This adds a new global and should have been labeled semver-major

Sep 20 '24 11:09 aduh95

It was added under a flag.

Sep 20 '24 13:09 KhafraDev

node node copied to clipboard

lib: add EventSource

node
node copied to clipboard