Benjamin Gruenbaum comments

Results 788 comments of


                                            Benjamin Gruenbaum

State outside of the render tree

I am not suggesting you remove `useStore` since I do see the value of the hook being render-aware (though your current reactivity system is _very_ coupled to the render tree)....

State outside of the render tree

@shairez I still owe Misko a gist for why I want DI/services as a concept - I think DI can be done _much nicer way_ than in React context and...

State outside of the render tree

And of course this also solves Reactivity's globality which I think is what Manu didn't like in my example above

Feature: generator prompt for html5mode support

:+1: really want to see this done.

Add a bit more structure to the tests

This is good, thanks

`performance.mark` doesn't exist in node@16 when using jsdom globals

While it's not strictly a bug I think it's very reasonable to support this use case and the fix shouldn't be too hard.

ClockDate class overwrite prototype of instance

This is probably a bug because when you `new` something in JS and return something different from the constructor - it will return that thing. ``` class Foo { constructor()...

ClockDate class overwrite prototype of instance

> Where do we do that? I could not see this happening in the example code. Our `ClockDate` function doesn't use `this` and instead has a return value even for...

Event timeStamp not using fake-timers

We can (probably) mock `KeyboardEvent.prototype.timeStamp` to return the fake time?

Safari test run breaks in Sauce Lab due to missing W3C WebDriver support

Would it make sense to just migrate to WebDriverIO? @christian-bromann given the visibility and popularity of this project is this something you can assist with? (feel free to say "no",...