Benjamin Gruenbaum

@christian-bromann thanks for the quick response it's appreciated! 🙏 The logic for running mocha tests in browsers isn't in min-webdriver it's in mochify. That could (at least optionally?) just use...

Great, @itayperry is this something you'd be interested in contributing? It could be a good chance to contribute to another project too (WebdriverIO)

> (ie. if you were to mock Date.prototype.getTimezoneOffset and then call FakeTimers.install your mock would be shadowed and inaccessible). Why is that - the source code indicates this should work...

Cc @littledan I remember you asking for feedback on Temporal. Is there anything other than .now that sinon would need to fake?

When does it land in Chrome?

So here's the thing: promise libraries and other libraries use nextTick and microticks for scheduling so this is a pretty big breaking change. In principle I agree that we should...

@SimenB I am +1 on this change in principle but I know it will break pretty much every fake-timers install "in the wild" that uses the current API.

> Should work if people use the builtin Promise and async-await, no? If it breaks builtin Promise global I'd consider that a bug in node. It doesn't break the built...

Seems posible @SimenB ```sh ➜ node git:(master) node Welcome to Node.js v16.10.0. Type ".help" for more information. > let orig = require('timers/promises').setTimeout; undefined > require('timers/promises').setTimeout = function (fn) { fn();...

That sounds reasonable, I think the current behaviour is expected but the use-case wasn't considered and the breakage wasn't expected. Alternatives I can think of: - Expose a `--no-primordials` flag...