fake-timers icon indicating copy to clipboard operation
fake-timers copied to clipboard

Add a bit more structure to the tests

Open mansona opened this issue 3 years ago • 3 comments

Purpose (TL;DR)

This Change just splits existing tests into their own files to make it a bit easier to manage (rather than one giant file with all the tests in it). I was motivated to do this when I wanted to create a failing test related to potential bug that I might have found and I found it difficult to figure out where to put my test.

I only moved the tests related to bug reports (i.e. they referenced an issue number) for now so we can decide if we're ok with this approach before splitting the main test file up any more 👍

mansona avatar Jun 14 '22 12:06 mansona

This is good, thanks

benjamingr avatar Jun 14 '22 20:06 benjamingr

Codecov Report

Base: 95.51% // Head: 95.52% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (a0f1f85) compared to base (bb28fea). Patch coverage: 95.83% of modified lines in pull request are covered.

:exclamation: Current head a0f1f85 differs from pull request most recent head f9189d9. Consider uploading reports for the commit f9189d9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   95.51%   95.52%   +0.01%     
==========================================
  Files           1        2       +1     
  Lines         624      648      +24     
==========================================
+ Hits          596      619      +23     
- Misses         28       29       +1     
Flag Coverage Δ
unit 95.52% <95.83%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/helpers/setup-tests.js 95.83% <95.83%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 14 '22 20:06 codecov[bot]

Strange that this fails ... 🤔

      AssertionError: [assert.greater] true: Expected 1655236965447 to be greater than 1655236965447

Node 14. Some setup missing?

fatso83 avatar Jun 17 '22 14:06 fatso83

rebased and fixed flaky test

fatso83 avatar Nov 21 '22 16:11 fatso83