Benjamin Gruenbaum comments

Results 788 comments of


                                            Benjamin Gruenbaum

HTTP Date header time faking fails on Node 15.2.0 and later

Hmm, @aduh95 what do you think?

HTTP Date header time faking fails on Node 15.2.0 and later

@gorankarlic Antoine's PR landed in Node - can you please take a look :)?

HTTP Date header time faking fails on Node 15.2.0 and later

I think the point of `-r internal/test/binding` is that it exposes a `primordials` global object with access to all the primordials (the locked object) - in our case we would...

HTTP Date header time faking fails on Node 15.2.0 and later

The primordial itself is not but its properties are. Nothing is stopping us from doing this for example: ``` ➜ Code git:(main) node --expose-internals -r internal/test/binding -e "primordials.Date.now = ()...

HTTP Date header time faking fails on Node 15.2.0 and later

But I think we can override the methods called after `new Date()` which are called (like toUTCString() and valueOf()) instead can't we?

HTTP Date header time faking fails on Node 15.2.0 and later

I can just make a PR to node to not do [this](https://github.com/nodejs/node/blob/fa0c6883a65737e0135b107f5e886acbdfb89ec5/lib/internal/per_context/primordials.js#L424) when the --expose-primordials flag is set probably?

HTTP Date header time faking fails on Node 15.2.0 and later

Let's see how it goes https://github.com/nodejs/node/pull/40733

toStream is not rxjs compatible

@benlesh does the fix look good?

What is a good way to prevent or warn about promise-observable mapping issues?

@spion-h4 hey what happened to your GitHub?

feat(fetch): add support for file urls in fetch

> We need a way to control the security of this. There are quite a few possible attacks when reading files from disk on servers. So your concern is that...