bendk
bendk
I think I fixed the error, but I feel bad putting you through this feedback loop. If it's too much, I can probably get someone from the suggest and/or sync...
Sorry, just getting back from PTO. I don't know what caused that git error, I don't see it locally. I rebased to the current main and re-pushed, maybe that will...
I think all the errors should be fixed now. @linabutler helped me get this one working.
I think Lina mentioned that those tests were failing intermittently. It's hard to see why this change would affect that. I just rebased and re-pushed, maybe they'll work this time?...
Looks like 1 of those tests is still failing. I'm not sure what the next step should be here, I kind of want to say it's an intermittent failure, but...
Looks like it was my fault. Lina says that my changes to `MockProfile` were breaking the tests and reverting them should fix it. Just pushed a new commit that does...
We've decided to stop storing unparsable records and simply always drop and recreate the suggestions DB whenever the schema is updated.
Yes it was, I was wondering where it went and why I had to close that issue twice :rofl:
Updated this PR to not hash the URLs for now at least. AFAICT, these are the remaining open questions: - Is the external API okay (passing a `Suggestion` object into...