mozilla-mobile
Add [v124] Pass in a data path to the suggest component
:scroll: Tickets
:bulb: Description
This sends a data path to the suggest component, which we will need once we start storing persistent data.
This is a pretty simple change, but I wrote it completely blind and also I don't have enough iOS knowledge to know if I'm choosing the correct path here. I need someone to a) run the tests and see if they pass and b) check that I'm putting the persistent data in the right directly.
:pencil: Checklist
You have to check all boxes before merging
- [x] Filled in the above information (tickets numbers and description of your work)
- [x] Updated the PR name to follow our PR naming guidelines
- [ ] Wrote unit tests and/or ensured the tests suite is passing
- [x] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
- [x] If needed I updated documentation / comments for complex code and public methods
I think my lastest push should fix that. swiftlint was passing for me locally at least after it.
I think I fixed the error, but I feel bad putting you through this feedback loop. If it's too much, I can probably get someone from the suggest and/or sync team with a mac to make sure it compiles correctly.
Sorry, just getting back from PTO. I don't know what caused that git error, I don't see it locally. I rebased to the current main and re-pushed, maybe that will fix it?
I think all the errors should be fixed now. @linabutler helped me get this one working.
I think Lina mentioned that those tests were failing intermittently. It's hard to see why this change would affect that. I just rebased and re-pushed, maybe they'll work this time?
IIUC, some of that behavior is going to be changing soon as well (discussion in https://github.com/mozilla-mobile/firefox-ios/pull/18732).
Looks like 1 of those tests is still failing. I'm not sure what the next step should be here, I kind of want to say it's an intermittent failure, but I don't have enough knowledge to say one way or the other.
Sorry for the hassle with this one, what do you think should be the next step?
Looks like it was my fault. Lina says that my changes to MockProfile were breaking the tests and reverting them should fix it.
Just pushed a new commit that does that, let's hope it works.
| Messages | |
|---|---|
| :book: | Project coverage: 33.68% |
| :book: | Edited 2 files |
| :book: | Created 0 files |
Client.app: Coverage: 32.5
| File | Coverage | |
|---|---|---|
| Profile.swift | 24.54% | ⚠️ |
CredentialProvider.appex: Coverage: 19.31
| File | Coverage | |
|---|---|---|
| Profile.swift | 24.54% | ⚠️ |
NotificationService.appex: Coverage: 22.86
| File | Coverage | |
|---|---|---|
| Profile.swift | 24.54% | ⚠️ |
ShareTo.appex: Coverage: 33.88
| File | Coverage | |
|---|---|---|
| Profile.swift | 24.54% | ⚠️ |
libStorage.a: Coverage: 59.53
| File | Coverage | |
|---|---|---|
| RustFirefoxSuggest.swift | 0.0% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against 073c82b14955a0502746a138fcbf4763573b1a3d
