bendk

> Per Lina's comment, we'd like to avoid those legacy insecure hashers (e.g. MD5) in Places, shall we follow that here as well? Good point. I just went ahead and...

> Would it be a bad idea to have a single check-for-dismissals step at the end of `fetch_suggestions()`? It seems a little onerous to have to add a subquery (or...

AFAICT, there's no major blockers left. How do others feel about merging this one, then following up on: - Simplifying the code by removing the sub-queries on each suggestion -...

Follow ups: - https://bugzilla.mozilla.org/show_bug.cgi?id=1886477 - https://bugzilla.mozilla.org/show_bug.cgi?id=1886484

Thanks for the review! I just updated a bunch of code based on the suggestions. I think you're right that the real interesting part will come from integrating with Necko....

Putting this up slightly early for feedback, but don't merge until Android and iOS is using the `SuggestStoreBuilder` ([iOS PR](https://github.com/mozilla-mobile/firefox-ios/pull/18732), [Android PR](https://github.com/mozilla-mobile/firefox-android/pull/5546))

See #6147 for how this will be used.

Pushing this one out again because: - The Android and iOS PRs are both merged! Nothing is blocking this anymore - I realized that my scheme to automatically delete some...

> For Async Rust, it's too early to commit to embracing it but I would love to see a small component running using Async Rust as support. I wouldn't want...

Thanks for all the feedback here. I just pushed an update with a bunch of changes, the main ones are: * Significantly re-framed the wrapper questions. Instead of "do we...