bendk

Results 297 comments of bendk

It would be a crate for just the UDL. It does feel a bit odd, but I'd prefer it over having a bunch of small UDL files with 1 enum...

It's really hard to tell how often this is happening because it's getting grouped with other issues in Sentry. It seems like switching sync manager to uniffi might fix this...

@mhammond and I have been discussing updating the `places::run_maintenance()` function to do more to reduce disk space by pruning unneeded data. Maybe we should also pick this one back up...

My first try is to log a breadcrumb with the `url::Parse` error when we see it. I don't think it should leak any PII (https://docs.rs/url/latest/url/enum.ParseError.html).

I need to understand the sync15 / sync15-traits split better to comment on this one. Couple questions here: - What was the motivation behind the split? I thought there was...

> It might also be possible to merge sync15 and sync15-traits with more aggressive features to avoid pulling unused code into desktop (currently webext-storage does not depend on sync15, so...

I'm running into a couple issues with this one: Sometimes the `RunCbindgen.py generate_metadata` command fails with an error because it's running `cargo metadata --frozen`. I'm not sure exactly what triggers...

@ncalexan Here's my last try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1beef3982a6a817544b4fb26285167cb276086e. It's a few days old at this point, but I think it covers all the issues. BTW, one of the URLs that I've...

I think the current code is close, but I don't think we should immediately rush to try to implement this for a couple reasons: - we should finish improving our...

My first attempt to narrow this down is checking if the login has `form_action_origin` or `http_realm` set. My hunch is that it's one kind or another that generates the duplicates.