Ben Manes

Potential false positive in complex method

1

I have a [complex method](https://github.com/ben-manes/caffeine/blob/ace16b76481b879d3629e23d45b4177f2e9629b4/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java#L547) that, sadly, seems worse when broke apart. So while none of my tests fail, I cannot be certain myself that there is not a bug....

False positive with field nullability stored in local variable

18

In this case, a `@Nullable` field is stored to a local variable. When the field is used in a null condition an error occurs, but if the variable is used...

Use Guava's testlib for queue coverage

2

Guava's testlib is a JUnit package that provides single-threaded test coverage for Java collections. An example usage would look something like, ``` java public final class QueueTests extends TestCase {...

Use Guava's testlib for increased test coverage

6

Guava provides a convenient [testlib](https://github.com/google/guava/tree/master/guava-testlib) for their collection tests. This can be used for other collection implementations, making a handy second set of tests to catch oversights. For example it...

Excessive finalization due to creating thread pools

1

When profiling for high memory usage, I noticed that Awaitility uses a finalizable executor by default. The default usage of `Executors.newSingleThreadExecutor` will wrap the thread pool with a `FinalizableDelegatedExecutorService` to...

Adaptivity

1

As you observed with the Youtube trace, the static configuration of W-TinyLFU is not optimal across all workloads. We spent some time exploring options and have a really good solution...

Fix unit factor usage in Caffeine cache

5

Fix the calculation based on what @aseovic explained to me over slack. I had mistakenly thought this was to change the base unit of the entry's weight, e.g. from bytes...

ConcurrentLinkedHashMap --> Caffeine when Java-8 based

3

When transitioning to requiring Java 8, please upgrade to [Caffeine](https://github.com/ben-manes/caffeine). The [performance](https://github.com/ben-manes/caffeine/wiki/Benchmarks) should be relatively the same and the per-instance memory usage should be smaller. [ConcurrentLinkedHashMap](https://code.google.com/p/concurrentlinkedhashmap/) changes will continue to...

javac warnings in generated code

1

To help maintain code health, we build with `-Xlint:all -Werror` by default. The generated thrift types and services contain warnings such as, ``` warning: [unchecked] unchecked generic array creation of...

Support object enum

2

JsonSchema allows for enumerations of objects, not just strings. For complex workflows this is very beneficial, e.g. ```json "status": { "type": "object", "properties": { "foo": { "type": "string", }, "bar":...