seldon-server icon indicating copy to clipboard operation
seldon-server copied to clipboard

ConcurrentLinkedHashMap --> Caffeine when Java-8 based

Open ben-manes opened this issue 9 years ago • 3 comments

When transitioning to requiring Java 8, please upgrade to Caffeine. The performance should be relatively the same and the per-instance memory usage should be smaller.

ConcurrentLinkedHashMap changes will continue to be minimal, even more so now, and driven by requests from Java 6 users unable to upgrade. Caffeine is ideally the upgrade path for Guava cache users too, which due to Android cannot be significantly modified.

ben-manes avatar Apr 11 '15 01:04 ben-manes

Thanks for the info. Certainly be good to test Caffeine as a replacement and see if it helps in load tests when we move to Java 8.

ukclivecox avatar Apr 14 '15 12:04 ukclivecox

If you upgrade from 1.2 to 1.4.2 you'll have much better cache performance, about the same as Caffeine. From there the benefit of upgrading will be better memory management and many more features.

ben-manes avatar Apr 14 '15 17:04 ben-manes

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. /lifecycle stale

seldondev avatar Apr 17 '20 07:04 seldondev