scrooge icon indicating copy to clipboard operation
scrooge copied to clipboard

javac warnings in generated code

Open ben-manes opened this issue 11 years ago • 1 comments

To help maintain code health, we build with -Xlint:all -Werror by default. The generated thrift types and services contain warnings such as,

warning: [unchecked] unchecked generic array creation of type T[] for varargs parameter

It would nice to have the code contain SuppressWarnings where appropriate so that the code is lint free.

P.S. This is on JDK6.

ben-manes avatar Apr 23 '13 18:04 ben-manes

There is a patch to address some of these: https://github.com/twitter/scrooge/pull/142.

Feel free to submit another one that fixes that particular warning.

nshkrob avatar Sep 22 '14 21:09 nshkrob