Brad Hess

Results 10 comments of Brad Hess

Is there more context on why this change is needed? It took me a long time to root cause why a package update to google.golang.org/grpc broke clients. Turns out that...

Ack, thanks for the explanation. Our code was calling that setter in grpc::ClientContext mostly because it seemed like a not-unreasonable thing to mark idempotent operations as such -- not necessarily...

That actually wasn't so bad, and the consolidation of args and flags into clauses makes this impl a lot cleaner.

Hey @alecthomas just wanted to ping and say there's an update-- not sure that you were notified. There's no urgency on my side, so not trying to hound. :)

Currently working on porting the Cloud KMS Java samples from the Apiary client to the GAPIC clients, and this is a gap. I'm looking for this to be exposed in...

@sduskis - did this get deprioritized? This functionality is fairly important for gathering good metrics. Can we get this scheduled?

@slevenick friendly ping - can you add a /gcbrun so we can get this moving? Thanks. :)

Friendly ping @slevenick - I don't understand what's broken here (just flakes?) and I am unable to repro on my own machine.

Ultimately I tracked this down to gazelle including a very old [golang.org/x/oauth2](https://github.com/bazelbuild/bazel-gazelle/blob/c11d7ce0133088d69e5a18541f219490cc3c1996/deps.bzl#L300-L306) by default. I was able to work around it by following Gazelle's [instructions](https://github.com/bazelbuild/bazel-gazelle#running-gazelle-with-bazel) to include my own `go_repository`...