magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

kms: Add support for the MAC key purpose.

Open bdhess opened this issue 3 years ago • 9 comments

Adds support for the new MAC key purpose in Cloud KMS.

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).

  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.

  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).

  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).

    Tests failed to run:

 ❯ make testacc TEST=./google TESTARGS='-run=TestAccKmsCryptoKey_hsmMacKey'

==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
go generate  ./...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccKmsCryptoKey_hsmMacKey -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
# github.com/hashicorp/terraform-provider-google/google [github.com/hashicorp/terraform-provider-google/google.test]
google/privateca_operation.go:50:167: undefined: time
google/privateca_operation.go:58:9: undefined: json
google/privateca_operation.go:61:121: undefined: time
google/provider.go:1086:68: undefined: resourcePubsubLiteReservation
FAIL    github.com/hashicorp/terraform-provider-google/google [build failed]
FAIL
make: *** [testacc] Error 2

Release Note Template for Downstream PRs (will be copied)

kms: Added support for the MAC key purpose

bdhess avatar Oct 18 '21 15:10 bdhess

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

modular-magician avatar Oct 18 '21 15:10 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 70 insertions(+), 3 deletions(-)) Terraform Beta: Diff ( 4 files changed, 71 insertions(+), 4 deletions(-))

modular-magician avatar Oct 18 '21 15:10 modular-magician

@slevenick friendly ping - can you add a /gcbrun so we can get this moving? Thanks. :)

bdhess avatar Oct 20 '21 21:10 bdhess

/gcbrun

slevenick avatar Oct 21 '21 18:10 slevenick

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 70 insertions(+), 3 deletions(-)) Terraform Beta: Diff ( 4 files changed, 74 insertions(+), 3 deletions(-))

modular-magician avatar Oct 21 '21 18:10 modular-magician

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_ComposerV2|TestAccComputeFirewall_firewallWithTargetTagsExample|TestAccProject_migrateParent|TestAccKmsCryptoKey_hsmMacKey|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211913

modular-magician avatar Oct 21 '21 21:10 modular-magician

Friendly ping @slevenick - I don't understand what's broken here (just flakes?) and I am unable to repro on my own machine.

bdhess avatar Oct 26 '21 15:10 bdhess

Oops, hope this fixes it

bdhess avatar Feb 04 '22 15:02 bdhess

@bdhess could you rebase this PR?

melinath avatar Jun 07 '22 21:06 melinath