kingpin icon indicating copy to clipboard operation
kingpin copied to clipboard

Published 20 hours ago • verified publisher icon alecthomas

Completion enhancements

Open bdhess opened this issue 7 years ago • 7 comments

Tried to break this up into logical chunks so that it's easier to review. Happy to squash if you'd prefer to look at it that way.

bdhess avatar Jul 09 '17 18:07 bdhess

Sorry to pull this on you, but I'm not accepting enhancement pull requests against master. Can you reapply to the v3-unstable branch?

I will be moving that branch to master soon.

alecthomas avatar Jul 09 '17 19:07 alecthomas

That actually wasn't so bad, and the consolidation of args and flags into clauses makes this impl a lot cleaner.

bdhess avatar Jul 09 '17 20:07 bdhess

Fantastic! Thank you. I'll take a look tomorrow.

alecthomas avatar Jul 10 '17 05:07 alecthomas

Hey @alecthomas just wanted to ping and say there's an update-- not sure that you were notified. There's no urgency on my side, so not trying to hound. :)

bdhess avatar Jul 18 '17 18:07 bdhess

Just got back from holidays, I will take a look soon.

alecthomas avatar Jul 28 '17 04:07 alecthomas

Any news on this?

percona-csalguero avatar Oct 17 '17 13:10 percona-csalguero

Any news on this?

lexfrei avatar Dec 23 '19 18:12 lexfrei