Ben Heidemann

Results 76 comments of Ben Heidemann

> Thanks for the tidy up. As it's so extensive, it'll take me a while to do a full review, but rest assured, my eyes are on it. No problem...

@mpalmer thanks for the review! I have applied all of the suggestions, and pushed some commits with further improvements relating to your questions. Let me know if you'd like me...

@mpalmer I've marked this as a draft due to the CI failures, but the code changes should be ready to review and give feedback on :)

@mpalmer I've marked this PR ready for review. There's still a [CI failure](https://github.com/mpalmer/action-validator/actions/runs/13615395296/job/38057800703?pr=85) in the `build (1.64, *)` job, but this seems to have been introduced in a [prior commit...

> FYI, I am tracking your work with interest, I've just got very minimal time at present, hence no reviews / comments so far. Rest assured I'm still alive (I...

Since this is branched off from https://github.com/mpalmer/action-validator/pull/86, I've marked it as a draft until this is merged. I'll then rebase this PR and mark it as being ready for review.

@mpalmer now that https://github.com/mpalmer/action-validator/pull/86 has landed, I've rebased this PR and it's now ready for review

> Given the number of "globbing doesn't work exactly the same as GitHub's" issues that have been filed, I can't help but wonder: how similar are the matching semantics of...

@peaklabs-dev I'm on a cloud server. @djsisson Trouble is I'm not sure exactly what to look for. The docs imply this should "just work" but don't mention about SSL certs...

> it should be, but if it isnt just manually set the BASE_URL Even after manually setting `BASE_URL`, I still get SSL errors and the following error still persists: ```...