Ben Heidemann

Results 76 comments of Ben Heidemann

I got the tests running using the following hacks: 1. Rename the snapshot files to end in `.ts` so they can be transpiled during the build 2. Import the files...

@award28 thanks for the detailed write up! 😃 One of the solutions for glob validation I considered was exposing functions from JS - much like you've done to support reading...

> **Side Note:** I'm wondering if this per-platform entrypoint will be required regardless, or if WASI can build a per-platform executable if we provide it with `main.rs`. For example, would...

> I'm not sure when stage 3 will happen, but we could always use this approach for the time being and migrate to WASI when the time is right. Yeah...

> I think that makes sense! I was originally hoping that we could use `wasm_bindgen` for something like pip as well to make action validator more accessible, but I misunderstood...

> > The only situation in which it would make sense to produce bindings for other languages (such as via Pyo3, Rutie, etc) is if people want to call into...

@award28 I guess N-API would still require the entrypoint function you discussed above to handle the arguments for multiple files (and everything else) correctly so I think we should keep...

> Ah I understand - if that's the case then what benefits do we gain for switching from wasm_bindgen to N-API? Is it the Glob validation? At present, it's the...

> I don't really have the expertise to make the best decision on this, I think. WASI does seem like a better approach than trying to tiptoe around the great...

I've had some success with compiling the binary to wasm32-wasi and consuming the resulting `*.wasm` file from Node. It is able to log to stdout and stderr, and well as...