action-validator icon indicating copy to clipboard operation
action-validator copied to clipboard

feat: NodeJS WASM CLI parity with native binary

Open bcheidemann opened this issue 10 months ago • 4 comments

Closes https://github.com/mpalmer/action-validator/issues/41 Closes https://github.com/mpalmer/action-validator/issues/76

This PR moves the CLI logic from JS to Rust by accessing system functions via a platform independent abstraction. This allows us to implement main in WASM, which gives us (near*) parity with the native binary.

This is based largely on exploratory work done by @award28 and documented in this comment.

*glob validation hasn't been implemented yet but can be implemented trivially with using the same mechanism

bcheidemann avatar Feb 21 '25 00:02 bcheidemann

@mpalmer I've marked this as a draft due to the CI failures, but the code changes should be ready to review and give feedback on :)

bcheidemann avatar Feb 21 '25 00:02 bcheidemann

@mpalmer I've marked this PR ready for review. There's still a CI failure in the build (1.64, *) job, but this seems to have been introduced in a prior commit already in main.

bcheidemann avatar Mar 02 '25 12:03 bcheidemann

FYI, I am tracking your work with interest, I've just got very minimal time at present, hence no reviews / comments so far. Rest assured I'm still alive (I think!), and keen to get this in when tuits permit.

mpalmer avatar Mar 03 '25 01:03 mpalmer

FYI, I am tracking your work with interest, I've just got very minimal time at present, hence no reviews / comments so far. Rest assured I'm still alive (I think!), and keen to get this in when tuits permit.

Haha 😁 Thanks for the FYI! Looking forward to your review, but no pressure from my end.

bcheidemann avatar Mar 03 '25 09:03 bcheidemann