Bryan Boreham

Note that range queries are always sorted by label sets, right at the end: https://github.com/prometheus/prometheus/blob/8b863c42dd956d35d18a7a0b39c89c86adf7cebf/promql/engine.go#L722 Perhaps you could mention in the documentation this is intended for instant queries.

I think it would be easy to work out that `sort` (by value) is not a good idea over a range, where different series can be the highest value at...

I’ll assume you are using the agent to send via remote-write. If not, please clarify. The WAL acts as a buffer between the scraping and sending side, and it is...

Commonly it is much worse to have to support two ways to do things instead of one. For instance testing effort more than doubles. Given disk space is the thing...

You could look at #4588, where the implementation was changed from an in-memory queue to reading the WAL.

Related idea: #7575, #7939.

Your complaint is about 29.36 milliseconds?

I think there is a bit of difference between server applications like Loki and Tempo, and promtail which is styled as an agent. You know you need to protect your...

> Are you saying you'd be open to PR submissions, or did you want to take a stab at it yourself? The former.

It's not something you added in this PR, but I wanted to note there is a simpler way to do `isDone()`: https://github.com/grafana/loki/blob/557e6e528059691911945bd7a26e8efded84cd08/pkg/ingester/instance.go#L683-L690 Just check `ctx.Err() != nil`, as in the...