Bryan Boreham

Results 990 comments of Bryan Boreham

Thanks for the PR. Can you describe how those attributes are useful for Kspan? It generates spans that claim to come from many different components such as kubectl, scheduler, controller-manager,...

Yes, might be safer to start just with the env-vars.

I see what you're saying, but that implies a tremendous amount of understanding about what each event means. I doubt if kspan will get that knowledge hard-coded in Go. Maybe...

@xuchen-xiaoying do you have a specific question or suggestion?

Here is the definition of `Event`: https://github.com/kubernetes/kubernetes/blob/5b1e5387591dd3ad0b3ddacc9e44a6ac7260078e/staging/src/k8s.io/api/core/v1/types.go#L5661-L5668 ``` type Event struct { metav1.TypeMeta `json:",inline"` // Standard object's metadata. // More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata metav1.ObjectMeta `json:"metadata" protobuf:"bytes,1,opt,name=metadata"` // The object that this...

@Belyenochi do you think you will come back to this?

Sorry it’s all a work in progress and there are no instructions. The program needs to connect to a Kuberenyes api-server to receive events; that is the error you got....

Nice! The pod will have to be able to contact Jaeger; you can set the `-otlp-addr` CLI flag to point to your host address, which the `docker ... -p` makes...

I have now set up Continuous Integration checks and stamped a version 0.0. Please use image `docker.io/weaveworks/kspan:v0.0` rather than the `dev` one. If you'd like to contribute a "how to...

You have this: ``` -otlp-addr=http://otlp-collector.monitoring.svc:55680 ``` Try `-otlp-addr=otlp-collector.monitoring:55680` (no `http` - it's a gRPC protocol)