Barry Hughes

> where we can't go back and add type hinting without breaking backcompat We are also constrained by our current minimum PHP requirements, as even for cases where we are...

@coreymckrill still in ideation mode, hence no corresponding tests, but pushed another change: - Leave backtrace generation to the logger. - Generalize the type checking method. - Implemented your idea...

[woocommerce_rest_pre_insert_shop_order_refund_object](https://github.com/woocommerce/woocommerce/blob/8.9.1/plugins/woocommerce/includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php#L313-L323) Tangentially related, I'm not sure that `Filters an object before it is inserted via the REST API` is quite accurate. At this point, the refund was potentially already persisted...

> I think such check is a very reasonable thing to do. So I think we have some consensus that this makes sense, and this feels like a reasonable way...

Sorry ... though it's fine to look at the code, I still need to update the PR description and testing instructions.

I think we're good to go now ... re-requesting review.

There's a test fail in CI that I didn't see locally. It *could* be related, so need to poke further: ``` 1) WC_REST_Products_Controller_Tests::test_product_api_get_all_fields Exception: The SKU (pancake-1) you are trying...

Since my last update... - The test fail [noted here](https://github.com/woocommerce/woocommerce/pull/47918#issuecomment-2197750632) was unrelated (rebasing and re-running CI solved it). - I added some linting fixes. - One of these was in...

> @barryhughes could you shed some light on the repository @frosso linked, is this the actual source for selectWoo and should we be editing the files there instead? Yes, in...

Thanks, @frosso: @naman03malhotra I assigned to you (the usual round-robin doesn't seem to work in that repo, and I have low availability next week so couldn't grab it myself).