Barry Hughes

Results 222 comments of Barry Hughes
trafficstars

Right, I mean since it is private and not inherited it could simply change from: `ActionScheduler_Store::bulk_cancel_actions( $action_ids )` To: `ActionScheduler_Store::bulk_cancel_actions_by_id( $action_ids )` The logic could remain the same. Though, of...

Sounds good! Once we're ready to pick this up, let's just verify this is the correct way round: > pass 'claimed' as true to the query to avoid triggering runners...

...We'd be receptive to a PR should you (or anyone) wish to submit one for this. Otherwise, we'll try and get to it in due course.

Hi! > However, it seems that wp_doing_cron() does not always return true when running "Action Scheduler" tasks. That's right. By default, there are up to three different contexts through which...

I'm sorry, I misunderstood. > However, there is currently no easy way to check whether a script is running in one of the 3 contexts mentioned? I'm not sure how...

> It would be nice if this library introduced it's own DOING_ACTION_SCHEDULER or something similar. Re-opening so we don't lose sight of this idea (a little unsure if defining a...

> It should be safe to remove the code that re-enables the hybrid store as the DBStore has been default for almost 4 years. For whenever we take this up:...

Wow, great catch... > Or it's out of AS responsibility? ... And a great question. It's not obvious, because it doesn't live in the vendor directory, but we're actually using...

Excellent, thank you @engahmeds3ed 👍🏼