Barry Hughes
Barry Hughes
It's not really a matter of one solution over the other (they don't seem to me to be mutually exclusive). > It just moves problem from "now" to "later". That...
> The idea with token as response does indeed only "green wash" the issue. The productimport then still needs a lot of time. What I've described is a [well-established pattern](https://www.mscharhag.com/api-design/rest-asynchronous-operations),...
> I think the paid solutions have a higher interest to keep their users happy. I don't think that is true. What is true, however, is that designing and rolling...
Feel free to request a fresh review once ready (I noticed the recent commits, but wasn't sure if you were perhaps still iterating on this).
Running CI, and if all passes we can go ahead and merge (this should then ship as part of the upcoming 9.3 release, scheduled for 2024-09-10).
## Alternative testing steps Since testing with AliPay may be problematic in some cases, here are some alternative steps. #### 1) Confirm normal behaviour This PR should not change any...
Seems like our automated checks didn't run as expected, so closing and re-opening to trigger a re-run.
@gedex can you resolve the conflict and perhaps rebase? We need to solve the conflict in any case, but also hoping this jolts CI into action.
Adding a couple of thoughts: > Should be a static method in a new `CouponUtil` class > ... > [Should] anything else should qualify for moving into a `DiscountsUtil` class...
Thanks! Good to merge on my end, unless we want either of the other reviewers to approve first?