Barry Hughes

Yes—that's the primary technical focus. The support aspect is one of the motivations for doing this, and something we'll look to alleviate through those changes.

``` ActionScheduler_ActionFactory::repeat() classes/ActionScheduler_ActionFactory.php:233 ``` ↑ This is already caught, by `ActionScheduler_Abstract_QueueRunner::schedule_next_instance()`, which is the only location where we call it. Third parties invoking this directly are responsible for their own...

``` ActionScheduler_Store::validate_args() classes/abstracts/ActionScheduler_Store.php:324 ``` ↑ This is already caught, by `ActionScheduler_DBStore::fetch_action()`, which is the only location where we call it. Third parties invoking this directly are responsible for their own...

``` ActionScheduler_Store::validate_action() classes/abstracts/ActionScheduler_Store.php:359 ``` ↑ This is already caught, by `ActionScheduler_DBStore::save_action_to_db()` Third parties invoking this directly are responsible for their own exception handling 🟢

``` ActionScheduler_Abstract_QueueRunner::process_action() classes/abstracts/ActionScheduler_Abstract_QueueRunner.php:64 ``` ``` ActionScheduler_Abstract_QueueRunner::process_action() classes/abstracts/ActionScheduler_Abstract_QueueRunner.php:95 ``` ↑ Both of the above are part of the current nested try/catch used for error handling. The exceptions are caught in the...

``` ActionScheduler_Abstract_ListTable::get_bulk_actions() classes/abstracts/ActionScheduler_Abstract_ListTable.php:162 ``` ↑ Unclear who/what we're guarding against here. I'd think if a bulk action lacks a valid callback, we should log that but simply omit it from...

``` ActionScheduler_WPCLI_QueueRunner::__construct() classes/WP_CLI/ActionScheduler_WPCLI_QueueRunner.php:33 ``` ↑ This code should only run in the context of WP CLI. The exception seems justified, no follow-up needed at present 🟢

``` ProgressBar::__construct() classes/WP_CLI/ProgressBar.php:47 ``` ↑ This code should only run in the context of WP CLI. The exception seems justified, no follow-up needed at present 🟢

``` ActionScheduler_DBStore::save_action_to_db() classes/data-stores/ActionScheduler_DBStore.php:113 ``` ``` ActionScheduler_DBStore::save_action_to_db() classes/data-stores/ActionScheduler_DBStore.php:118 ``` ``` ActionScheduler_DBStore::save_action_to_db() classes/data-stores/ActionScheduler_DBStore.php:126 ``` ↑ For all of the above, the exception is thrown from within a private method but we trigger...

``` ActionScheduler_DBStore::get_query_actions_sql() classes/data-stores/ActionScheduler_DBStore.php:397 ``` ``` ActionScheduler_DBStore::get_query_actions_sql() classes/data-stores/ActionScheduler_DBStore.php:455 ``` ``` ActionScheduler_DBStore::get_query_actions_sql() classes/data-stores/ActionScheduler_DBStore.php:470 ``` ``` ActionScheduler_DBStore::get_query_actions_sql() classes/data-stores/ActionScheduler_DBStore.php:493 ``` ↑ These are all within `ActionScheduler_DBStore::get_query_actions_sql()`. It's called from various public API functions like...