Bard Liao

Results 188 comments of Bard Liao

> Pretty sure some of those properties are used in the kernel, e.g. the MAX_PPL_COUNT. Adding @RanderWang and @bardliao for comments. Yes, some of them are used in the kernel....

> * *change SSP1's direction to duplex instead of playback > > For the last change, not sure if this is a bug, without the change, capture on SSP0 will...

@lgirdwood Can we enable loopback mode? https://github.com/thesofproject/sof/blob/73a413a38fc24a9763ac55df9ebb528219c5d139/tools/topology/topology1/sof-smart-amplifier.m4#L244 Set SMART_SSP_QUIRK in the topology can enable loopback mode, am I right?

It seems smart amp topology doesn't support LBM. So, I edit nocodec topology to fit the product to test loopback mode. https://github.com/bardliao/sof/commit/f1ea06a847ac3e8a8549402b64a9d07adaac70f2 The loopback wav looks pretty good to me....

BTW, If someone can probe the I2S pins physically with a logic analyzer to get the audio data from I2S pins directly, it would be a better way to clarify...

I can hear pop noise when speaker playback starts **AND** stops. And I also hear obvious pop noise when headphone playback stops. The test wav is [1K_0dB.zip](https://github.com/thesofproject/sof/files/9878325/1K_0dB.zip)

@ujfalusi @lgirdwood @macchian I am pretty sure the pop is from the codec itself after doing some experiment. There are two speaker codecs (left and right) in the device. And...

> Hi @mengdonglin , From Maxim's debugging results, it looks like not relevant to codec or DSM issue. Because the experiments below still hear the pop sound. There is 300Hz...

> @bardliao @RanderWang are those topologies used in CI? Or can you share what they look like with the png image? No, they are not used in CI. ![cavs-tgl-nocodec](https://user-images.githubusercontent.com/8856808/192272583-cd36005d-d2aa-4de0-96bd-71e2e93ed6ae.png)

> @bardliao @RanderWang which platform were you able to test this on ? I tested it on TGL