sof
sof copied to clipboard
thesofproject
ipc4: remove report dsp properties to host driver
The ADSP properties are obsolete and not using by host driver so can be removed.
Signed-off-by: Damian Nikodem [email protected]
Pretty sure some of those properties are used in the kernel, e.g. the MAX_PPL_COUNT. Adding @RanderWang and @bardliao for comments.
Pretty sure some of those properties are used in the kernel, e.g. the MAX_PPL_COUNT. Adding @RanderWang and @bardliao for comments.
Yes, some of them are used in the kernel. Please don't remove it.
Pretty sure some of those properties are used in the kernel, e.g. the MAX_PPL_COUNT. Adding @RanderWang and @bardliao for comments.
ipc4 fw also supports windows which requires these properties and we will add more missed.
@dnikodem ok, it looks like these will need to be optional as some driver may use and others may not use.
Thanks for your update - it is really helpful.
Ok, so now it is clear that the kernel uses MAX_PPL_CNT from DSP_PROPERTIES - removing it would cause regression.
I checked the code base also and in my opinion we can try to use FIRMWARE_CONFIG (extended ID 7) instead of DSP_PROPERTIES (extended ID 0) to get MAX_PPL_CNT. Could I ask for help with determining if the kernel/windows uses any other DSP properties?
If the kernel/windows uses MAX_PPL_CNT only, what do you think about such a change? (using FIRMWARE_CONFIG and removing DSP_PROPERTIES support as it is obsolete)
Thanks for your update - it is really helpful.
Ok, so now it is clear that the kernel uses MAX_PPL_CNT from DSP_PROPERTIES - removing it would cause regression.
I checked the code base also and in my opinion we can try to use FIRMWARE_CONFIG (extended ID 7) instead of DSP_PROPERTIES (extended ID 0) to get MAX_PPL_CNT. Could I ask for help with determining if the kernel/windows uses any other DSP properties?
If the kernel/windows uses MAX_PPL_CNT only, what do you think about such a change? (using FIRMWARE_CONFIG and removing DSP_PROPERTIES support as it is obsolete)
Sounds like a topic for next Tuesday call. @mwasko fyi.
Pretty sure some of those properties are used in the kernel, e.g. the MAX_PPL_COUNT. Adding @RanderWang and @bardliao for comments.
ipc4 fw also supports windows which requires these properties and we will add more missed.
@RanderWang Windows driver do not use ADSP Properties, it ask only for IPC4 HW Config and FW Config. That is a reason why we want to clean IPC4 and remove unused ADSP properties.
Pretty sure some of those properties are used in the kernel, e.g. the MAX_PPL_COUNT. Adding @RanderWang and @bardliao for comments.
Yes, some of them are used in the kernel. Please don't remove it.
@bardliao as far as I can tell all the ADSP properties fields can be read either from FW Config (e.g. MAX_PPL_COUNT) or HW Config. Keeping it duplicated is not a good approach so the recommendation is to remove ADSP properties and use FW and HW config instead.
Pretty sure some of those properties are used in the kernel, e.g. the MAX_PPL_COUNT. Adding @RanderWang and @bardliao for comments.
Yes, some of them are used in the kernel. Please don't remove it.
@bardliao as far as I can tell all the ADSP properties fields can be read either from FW Config (e.g. MAX_PPL_COUNT) or HW Config. Keeping it duplicated is not a good approach so the recommendation is to remove ADSP properties and use FW and HW config instead.
it's fine to clean things up @mwasko but it's an ABI change. this cannot be done without a real process.
Thanks for checking @kv2019i . @ujfalusi good for you too after checking now ?