[DOC] Added Type Hints for _dilated_shapelet_transform

[aryanpola]

What does this implement/fix? Explain your changes. I have added type hints for function variables and return values as described in issue. #1910

[aeon-actions-bot[bot]]

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually. I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

• [ ] Run pre-commit checks for all files
• [ ] Run all pytest tests and configurations
• [ ] Run all notebook example tests
• [ ] Run numba-disabled codecov tests
• [ ] Stop automatic pre-commit fixes (always disabled for drafts)
• [ ] Push an empty commit to re-run CI checks

[MatthewMiddlehurst]

Hi, I can take a look at this in a bit if you are still having issues. Feel free to @ me with any questions. @baraline left a comment on your previous PR so im sure he would be open to questions as well

[aryanpola]

@baraline Is there any reason for the tests to be canceled, they were all successful when I committed but got canceled when I updated the branch.

[baraline]

I don't think that should be happening, let me check

[baraline]

Some changes were made to the file you are working with on #1959, which added two parameters to the _init_random_shapelet_params and random_dilated_shapelet_extraction function, which both are ndarray of integers. (need to merge main to see them). Edit : also to dilated_shapelet_transform, the shapelet tuple with have two additional ndarrays Concerning the test, they seem to be canceling from time to time for yet unknown reasons, will keep an eye out and relaunch them if necessary.

[aryanpola]

Some changes were made to the file you are working with on #1959, which added two parameters to the _init_random_shapelet_params and random_dilated_shapelet_extraction function, which both are ndarray of integers. (need to merge main to see them). Edit : also to dilated_shapelet_transform, the shapelet tuple with have two additional ndarrays Concerning the test, they seem to be canceling from time to time for yet unknown reasons, will keep an eye out and relaunch them if necessary.

Are there any changes that I am supposed to make?

[baraline]

Yes, could you should first merge the main branch into this and had the type hints for the new parameters of the functions I listed ?

[aryanpola]

Yes, could you should first merge the main branch into this and had the type hints for the new parameters of the functions I listed ?

Added the type hints after merging the main branch. Is there anything else to do?

[baraline]

Just need to resolve the remaining conversation, and we'll be good to go I think ! 😄 (One from Matthew still need an action from you)

[aryanpola]

Looking good to me! Thanks for your patience! 😄

Thanks a lot for the help!