aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[DOC] Add type hints for shapelet-based collection transformation.

Open baraline opened this issue 1 year ago • 7 comments

Describe the issue

Other modules are increasingly using type hints in the function declaration, the shapelet-based tranformation module should do the same.

Suggest a potential alternative/fix

Add type hints to algorithms in aeon/transformations/collection/shapelet_based. One PR can be opened for each algorithm if preferred, as some are quite large.

Additional context

If you have any question, don't hesitate to ask directly here or contact us on Slack!

baraline avatar Aug 05 '24 06:08 baraline

@Datadote If this one is OK for you, you can assign yourself to it !

baraline avatar Aug 05 '24 06:08 baraline

Aeon-Assign bot assign @Datadote

Datadote avatar Aug 05 '24 14:08 Datadote

I don't remember if we have a bot for this, but you can do it manually on the Assignees tab on the right side, I'll do it for you this time. Happy coding, and thanks for contributing !

baraline avatar Aug 05 '24 15:08 baraline

There was an error in the docs that we have now fixed, but have to wait for a release for it to appear on the stable branch. Have to start with @aeon-actions-bot

MatthewMiddlehurst avatar Aug 06 '24 11:08 MatthewMiddlehurst

I think you need write access to manually assign yourself

MatthewMiddlehurst avatar Aug 06 '24 11:08 MatthewMiddlehurst

Yep, I don't have access to manually assign myself (Tried on other issues).

I started a draft pull request with type hints, and some styling questions in #1926 . Thank you for the help

Datadote avatar Aug 07 '24 00:08 Datadote

Aeon-Assign bot assign @aryanpola

aryanpola avatar Aug 10 '24 14:08 aryanpola