John Holland

Edited PR comments

Thanks for the suggestions. I'll work on fixing these issues. --------------------- John Holland a ***@***.******@***.*** On Sun, May 15, 2022 at 1:39 PM samwiseg0 ***@***.***> wrote: > 👋 > >...

I merged a pull request a few days ago that begins python 3 support. Unit tests are passing under both python 2 and 3. Included scripts are failing. See https://github.com/azoner/pyx12/tree/py3-fix-scripts

I will publish a new release to pypi when python 3 support is complete.

This will remove a dependence on a non standard library.

Thanks for spotting that. I will publish the latest version to PyPI.

Nice work. I want to think a bit about the interface changes necessary for repeated values. For backward compatibility, get_value() should return the element value for no repetitions and the...

I have not converted many of the 4010 maps to 5010, including the 271. If you have a copy of the implementation guide, it would be great if you could...

I like that idea in general. The external codesets are already in an external file - codes.xml. Users are free to make modifications to their local copy. state and country...

I will implement