pyx12 icon indicating copy to clipboard operation
pyx12 copied to clipboard

Adding repetition parsing / validation

Open minjit opened this issue 8 years ago • 4 comments

see title

fixes #6

minjit avatar Jun 22 '16 22:06 minjit

Nice work. I want to think a bit about the interface changes necessary for repeated values.

For backward compatibility, get_value() should return the element value for no repetitions and the formatted element list including the separator for repeats.

I'd like a get_values() method that returns a tuple(string). Elements with no repetitions would just have a single element tuple.

azoner avatar Jun 24 '16 20:06 azoner

Sure, I can take a look at that.

minjit avatar Jun 24 '16 21:06 minjit

Get_value was already backwards compatible. Added the get_values_list method. Named it that way for clarity and it returns a list instead of a tuple because we're building a list anyway, but can convert it to a tuple at the end if you'd prefer.

minjit avatar Jun 27 '16 22:06 minjit

Coverage Status

Coverage increased (+0.5%) to 67.526% when pulling 3ed47118a5131378d23bb5868864e8cdac28f78c on minjit:master into 2289ea8a657facc4879daeda2bb4ed0a8cfa688f on azoner:master.

coveralls avatar Jun 27 '16 22:06 coveralls