Adam Welc
Adam Welc
@villesundell, I approved the PR but I think you need to rebase to get rid of the incorrect link error.
I have only now fully processed your comment about telemetry/event protocol and its introduction to wait for Symbolicator to be ready, so here are some additional comments. I am not...
> @awelc The code has been updated and needs to be reviewed again. I am going to re-review it shortly, but I was wondering if you are going to put...
> > Symbolicator > > Since the current implementation of Symbolicator is asynchronous, the specific timing of Symbolicator depends on the size and running environment of the project, and by...
> @awelc I've done the refactoring, take the time to review it again. Thank you! And my apologies that it's taking time, but I want to make sure the code...
> Your analysis is correct, my problem now is that ci-test will fail if not synchronously waiting for symbol table resolution to complete. Another solution is to set a large...
> ok, waiting for your good news Let's see if the news are indeed good :-) I am sorry but the weekend was a bit busy and I only just...
> @awelc Do you have time to help with this PR? Been really busy... In any case, I have some comments and helped some other folks to take a look,...
FYI, https://github.com/move-language/move/pull/259 has landed.
> awelc I found that move-analyzer has several problems on windows platform: I will look into these tomorrow. We have only recently (and partially) enabled Windows support so the Move...