move icon indicating copy to clipboard operation
move copied to clipboard

[Move analyzer] Updated package info & clap usage

Open villesundell opened this issue 2 years ago • 5 comments

While move-analyzer --version reports 1.0.0, the package itself is at version 0.0.0. This is because version information is hardcoded to the clap() usage, and the Cargo.toml package manifest is out-of-date.

Updated Cargo.toml information: dropping Diem mentions and setting a proper version. Clap() usage was also changed to idiomatic one as per 9225b84aa ("Idiomatic "clap" usage (implements --version switch for tools) (#81)", 2022-05-02)

(Also tried to replace the author, but changing it doesn't pass the linter, so need to have another PR for changing the linting rule and all the mentions in every Cargo.toml, since that would be logically a different kind of change)

Motivation

There is a discrepancy between the package version, and version reported by move-analyzer --version. This was fixed by updating Cargo.toml and clap() usage accordingly. Also outdated information was updated/removed.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

cargo install --path language/move-analyzer --version 1.0.0 move-analyzer
target/release/move-analyzer --version

Also, installing the previous 0.0.0 should fail:

cargo install --path language/move-analyzer --version 0.0.0 move-analyzer

villesundell avatar Jul 18 '22 18:07 villesundell

I can't add reviewers, so asking review from my mentors @awelc and @tnowacki this way :memo:

villesundell avatar Jul 18 '22 18:07 villesundell

(The failed broken link check is fixed in #280)

villesundell avatar Jul 18 '22 19:07 villesundell

I'll leave this to @awelc

tnowacki avatar Jul 28 '22 18:07 tnowacki

@villesundell, I approved the PR but I think you need to rebase to get rid of the incorrect link error.

awelc avatar Jul 28 '22 21:07 awelc

@awelc Tests pass now, ready to be merged :+1: (I can't merge)

villesundell avatar Jul 30 '22 21:07 villesundell