Adam Welc

Results 121 comments of Adam Welc
trafficstars

> > awelc I found that move-analyzer has several problems on windows platform: > > I will look into these tomorrow. We have only recently (and partially) enabled Windows support...

> > And ... sadly I had another bug that I was tracking and it took all day. I should find some time tomorrow, though. > > OK Got it...

> @awelc I tested it, your PR did not fix the stack overflow problem, but I can solve it by referring to this [PR](https://github.com/starcoinorg/starcoin/pull/3445) Could you please tell me how...

> > @awelc I tested it, your PR did not fix the stack overflow problem, but I can solve it by referring to this [PR](https://github.com/starcoinorg/starcoin/pull/3445) > > Could you please...

I realized I did not actually submit the re-review comments that I put in last week, so here they are. With respect to the stack overflow fix, I don't think...

> > > > Now the version used in automated testing is 1.64.0, I upgraded to 1.69.2 to try. Just to make sure - when you install a locally packaged...

> Why does removing the `mid` function cause the edges in the hyper edge to be reordered though? What I think is happening is that when hyper edges are propagated...

The more I think about it, the more it seems to me like the fact that the problem occurs under one order and not the other is not the real...

To follow up on my line of thought (which is very possibly wrong), in `inner` you have: ``` borrowed_by: Reference($t0) -> {(.v (vector), Reference($t1))}, Reference($t1) -> {([], Reference($t3))} ``` Which...

I think I was not clear enough :-( In `inner` you have: ``` Reference($t0) -> {(.v (vector), Reference($t1))}, ``` where `$t1: &mut vector` and `$t0|has_vector: &mut m1::HasVector`, and we have:...