Martin Auswöger

Results 436 comments of Martin Auswöger

> Of course you cannot provide the same variable for all 3 contexts. What I imagined was that `foo` is marked safe for `html`, so it must get encoded in...

In `$GLOBALS['TL_LANG']['CNT']` they are still lowercase AFAIR, right? The only thing that got changed to uppercase is `tl_member.country` in c0e2e2923fae754d842fa596b60b11797d6fb635 I think.

The legacy modes are still supported, see https://github.com/contao/contao/blob/fdd1ceaf05f6e9c60139364e2b57727a8c06a3a6/core-bundle/src/Image/ImageFactory.php#L280 I think we can only remove the reserved names and the translations in Contao 6.

> Basically what the PR does right now, no? Yes, please change the milestone to 6.0

> Testing execution time of a simple PHP CLI command (php -r "echo 'Hello from CLI';") via proc_open shows around 280 ms delay. Did you test if passing the options...

My guess would be that the slowdown is either a problem with `cmd` on your system or a performance issue in the Symfony process handling for windows: https://github.com/symfony/symfony/blob/da8bc22646a8a1fbd5a283e7670aeb55dfb120f7/src/Symfony/Component/Process/Process.php#L1489

> This is default: [symfony/process@`7.3`/Process.php#L79](https://github.com/symfony/process/blob/7.3/Process.php?rgh-link-date=2025-07-30T08%3A36%3A03.000Z#L79) Yes, but Symfony itself prepends the command with `cmd.exe` in https://github.com/symfony/process/blob/40c295f2deb408d5e9d2d32b8ba1dd61e36f05af/Process.php#L1585-L1590 which probably causes the same slowdown as `bypass_shell: false` would.

> I have linked an directory structure from outside the contao root directory into the files directory. How exactly did you do that?

I was able to reproduce that error, it happens anytime the image gets output without resizing and therefore the original path is used. In https://github.com/contao/contao/blob/7557bdc199d2b0ad10686db4d54754dc750fc270/core-bundle/src/Image/Studio/FigureBuilder.php#L331 we get an absolute path...

@michael-j-r I don’t understand your last comment to this issue, you only repeated existing comments. Probably the “answer via email” feature of GitHub failed?