Martin Auswöger

Results 436 comments of Martin Auswöger

> So reloading should entirely be optional. Agree, that’s why I added https://github.com/contao/contao/blob/f0c5cc3ec6c2caa4ec10f9aea06de937b866cf5c/core-bundle/contao/library/Contao/DcaLoader.php#L97 > Secondly, I feel like this only works if we unset the global variable on reload. Is...

> But that would not allow to manipulate the URL and reload the DCA, right? Why not? ```php DcaLoader::reset(); $requestStack->push(new Request(…)); Controller::loadDataContainer('tl_content'); ``` This should work fine. But I just...

> This would reload **all** DCAs, not just a specific one, right? Yes, which is the desired behavior IMO because all loaded DCAs are potentially configured based on the request...

> So IMO we have to reset all DCAs if we want to reload a single one, in order to get a reliable result. This is how it is implemented...

> IMHO the concept like it is built right now should be merged. 👍 🥳

> `altcha/external/worker.js` Do we actually have to load this ourselfs? I think it should be enough to provide the path to it via the `workerurl` option.

I think there are some misunderstandings here: 1. Asking _“Will there be a solution to this?”_ on an open issue on GitHub is meaningless. As long as the ticket is...

Feedback: Return the breadcrumbs as KnpMenu? (@Toflar)

Can confirm. The `TableAccessVoter` does not handle the delete action so if the user can edit any fields is not checked for the delete action: https://github.com/contao/contao/blob/d42a6e40f1ed9be70f3bf5972b79b885bb1b548f/core-bundle/src/Security/Voter/DataContainer/TableAccessVoter.php#L38-L45 Not sure if we...