Martin Auswöger

Results 436 comments of Martin Auswöger

This method only seems to create useful output for arrays like `['value', 'value']` or `['key1' => ['value', 'value'], 'key2' => ['value', 'value']]`. All other array structures create strange outputs or...

This needs to be fixed in Contao 5.2 as well, as all content elements seem to be affected, not only nested ones.

I think I broke `BackendPreviewListener::getIdFromRequest()` in https://github.com/contao/contao/commit/eb37857c26de5fd3a230d583681e78ced0178ce4#diff-8223859aeb4b5c90b907606bd48bb61af8df95c1fe27643af4e91e32ee86dfd1 We should make sure that `getIdFromRequest()` always returns the ID of the article IMO.

Isn’t it possible that the same service has two methods that are tagged as a cron job? Should we instead store the service ID plus the method name?

Could also be a function instead of a filter I think.

> How to deal with exceptions? One solution could be a VFS wrapper, that catches exceptions … and maybe additionally limits the amount of exposed functions. Yes that makes most...

I think this could be problematic when using delimiters that are more than one character wide, e.g.: ```php $generator->generate('Hello World!', ['delimiter' => '%20']); // Result: hello%20world ``` In this case...

> …we need to increase the `challenge` column to a length of `128`… Agree. > Shall we use `SHA-512` and `200_000` then? Unless someone confirms that these settings work better,...

> * The extension allows `maxnumber` to be configured in the widget and its default is `10_000_000` whereas the core just uses `range_max` from the config for this (i.e. `100_000`...