Martin Auswöger comments

Results 436 comments of


                                            Martin Auswöger

Row size too large depends on history of table

Using `SET GLOBAL innodb_instant_alter_column_allowed=add_last;` or `SET SESSION alter_algorithm=COPY;` would also fix this issue. However we probably only want interfere with this if we absolutely have to, so we need to...

Row size too large depends on history of table

> Would it take too much time to simply just always run it? I think so, yes. In some cases this does a full copy of the table, so always...

Row size too large depends on history of table

> Would it make sense to introduce a `contao:optimize-tables` command Not sure if this is needed. You could just use `doctrine:query:sql 'OPTIMIZE TABLE tl_module'` for example.

Row size too large depends on history of table

> …if this **really** should be done e.g. once a month… > …if we are sure that this cannot break anything… I think it’s too dangerous to do that automatically...

Fix the encoded umlauts in JSON-LD data

> The encoding is either related to the `\DOMDocument` or the `Symfony\Component\DomCrawler\Crawler` itself. The encoding is done here: https://github.com/symfony/symfony/blob/78c6ceb5cd0560346b6765849f142c1c451fd1a8/src/Symfony/Component/DomCrawler/Crawler.php#L1088 IMO this is a Symfony bug, but I’m not sure how/if...

Fix the encoded umlauts in JSON-LD data

> Would you report that for Symfony? 😇 https://github.com/symfony/symfony/issues/54437

Fix the encoded umlauts in JSON-LD data

I still think the `contentUrl` should be changed to output `%C3%BC` instead of `ü` as this will probably also cause issues elsewhere. Is that part of your application code, or...

Change field type for `session` in `tl_user`

Can you provide a dump of that session that exeeds 64KB?

Change field type for `session` in `tl_user`

I think we should increase the size to `MEDIUMBLOB` then.

Replace more `$GLOBALS['objPage']` with the page finder service

Should be merged into `5.x` IMO