Martin Auswöger

Results 436 comments of Martin Auswöger

Seems that the rules of the unicode library think that `ё` should be transformed to `ё` and not to `yo` see https://github.com/unicode-org/cldr/blob/7825c7bfc1d036b9911e467c620c7cfe224ef45e/common/transforms/Russian-Latin-BGN.xml#L122-L132 Can you point me to the rules that...

There doesn’t seem to be a matching transform available in the CLDR: https://github.com/unicode-org/cldr/tree/main/common/transforms But you could still prepend your own rules to achieve the desired result: ```php $generator->generate($str, ['locale' =>...

This seems to be impossible to me. Or maybe I’m not understanding it correctly. Can you give an example how such a feature would look like?

@Rumi-Aguirre can you describe your use case in detail? Maybe with some examples?

> `"_sugiartoss_" -> "sugiartoss-"` so the behavior in the beginning of the string should be different than at the end of the string?

For this case it should be easy to remove the delimiter from one side after the generation, e.g.: ```php ltrim($generator->generate('-foo-', ['trimDelimiter' => false]), '-'); // foo- rtrim($generator->generate('-foo-', ['trimDelimiter' => false]),...

I adressed all review comments. Adressing this issue is quite important for us in order to get compatible with Doctrine 4.

> I think this lacks documentation, Should I add a section for `createComparator()` to *docs/en/reference/schema-manager.rst* ? Or should it be a new page about the Comparator itself? > and I'm...

Should I make the `Config` object itself also immutable?

> I think this lacks documentation Done in e117bbbfbd9a6968c5d7466d0f12398a279c79e4