Martin Auswöger

Results 436 comments of Martin Auswöger

Would the spec then fall back to the default `100vw` if none of the media conditions match?

@eeeps so `sizes=auto` is only allowed together with `loading=lazy`, right? Regarding extrinsic width and height, do you think the linter should report this as an error if they are missing?

`sizes=auto` is not yet shipped by any browser, right?

> At a minimum, `auto` should be an allowed `sizes` value. A better solution would check that images with `sizes=auto` were also lazy-loaded,… Done in cb36c068c7244df695cae30892e6a533c2082947 It checks now for...

See https://github.com/ausi/respimagelint/issues/75#issuecomment-1374481385

Should be fixed since 194f75598b0fc0e26bb3166a17a3e5ecbb25f30b if the issue still appears please open a new issue.

> Uncaught SyntaxError: JSON.parse:… Should be fixed since 194f75598b0fc0e26bb3166a17a3e5ecbb25f30b if the issue still appears please open a new issue.

Does the error also occur if you use the browser extension? https://chrome.google.com/webstore/detail/responsive-image-linter/mnddginionlghpblkimpdalcecpnbjln

We probably need to add a check if `currentRage` is `undefined` here: https://github.com/ausi/respimagelint/blob/194f75598b0fc0e26bb3166a17a3e5ecbb25f30b/src/util/computeSizesAttribute.js#L57-L58

Fixed in a95e53c24838c4d14fe726b1e1d1b39184bdfd38 Can you please verify if it works now for you?